-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/simple spinning #1728
Merged
Merged
Feature/simple spinning #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overheadhunter
requested changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Factories and Builder are pretty nice, however due to the number of duplications, I'd suggest to add a new class to org.cryptomator.ui.controls
and use it from within the fxml files:
public class Spinner extends FontAwesome5IconView {
public Spinner(@NamedArg("spinning") ObservableValue<Boolean> spinning) {
setGlyph(FontAwesome5Icon.SPINNER);
var animation = Animations.createDiscrete360Rotation(this);
this.animator = AutoAnimator.animate(animation)) //
.onCondition(spinning) //
.afterStop(() -> setRotate(0)) //
.build();
}
}
This reverts commit a1303ef.
* extends FontAwesome5IconView * by default animates if visisble * replace all iconViews only showing a spinner glyph by new class
overheadhunter
requested changes
Jul 26, 2021
overheadhunter
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR of #1704 .
The spinning logic is simplyfied by just rotating the IconView on certain conditions. The rotation is sequence of discrete rotations by 45° angle each. The subscription for the rotation needs to be stored because its binding is only weak and would be otherwise gc'ed.
Any appearance of class ProgressSpinner is replaced by a rotating IconView except in the health package due to outstanding PR #1712 .