Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/win installbundle with winfsp #2072

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

infeo
Copy link
Member

@infeo infeo commented Feb 23, 2022

This PR adds a new build artifact to our release gh action: An installation bundle.

An installation bundle is an executable which packages different standalone installers together and, on execution, installs those one after another in one user experience. The bundle is build with Wix, for more information see https://wixtoolset.org/documentation/manual/v3/bundle/.

This bundle packages the Cryptomator MSI with WinFsp to provide a better system integration on Windows directly after install and to prevent pitfalls caused by the WebDAV volume provider. It ships with its own license extended with a Winfsp clause.

Additionally, the local build scipt is extended to also build the bundle.

Remark: This is a history-cleaned version of #2071.

* via wix burn engine
* licenses generated on the fly
* customized theme
* local only
@infeo infeo added the type:enhancement Improvements on an existing feature label Feb 23, 2022
@infeo infeo added this to the 1.6.6 milestone Feb 23, 2022
@infeo infeo self-assigned this Feb 23, 2022
@infeo infeo mentioned this pull request Feb 23, 2022
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
dist/win/build.ps1 Outdated Show resolved Hide resolved
dist/win/bundle/customBootstrapperTheme.xml Outdated Show resolved Hide resolved
infeo and others added 2 commits February 24, 2022 09:46
Co-authored-by: Sebastian Stenzel <overheadhunter@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@infeo infeo merged commit 767bdba into develop Feb 28, 2022
@infeo infeo deleted the feature/win-installbundle-with-winfsp branch February 28, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Improvements on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants