Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent key recovery for foreign vault #2161

Merged

Conversation

overheadhunter
Copy link
Member

Prevent using a recovery key if a vault config file exists and the provided key didn't sign it.

This fixes #2076 and prevents people from "false positive key recoveries" that led to follow-up errors (empty vault).

Copy link
Member

@infeo infeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love this contribution 💚 : Reduced possibility to screw up a vault, reduced support on our side and improved usability.

Speaking about useability: Can you add in the ui a label with the cross icon when the text entered in the recover text box is not a valid recovery key. Otherwise the user would ask why she cannot click on the next button.

Like the positive case
grafik
and similar to the valid-path-label in the CreateNewVaultLocationController.

@overheadhunter
Copy link
Member Author

overheadhunter commented Apr 5, 2022

I tried but didn't succeed without adding a disproportionate amount of complexity in the fxml file, therefore I decided this issue is about preventing bad things from happening, not about explaining why a recovery key is considered invalid.

The button being disabled without explanation is not a regression, so let's not use the review to sneak in other new features. 😉

Copy link
Member

@infeo infeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well ok, worth a try. But then one step after another.

@overheadhunter overheadhunter merged commit 752e612 into develop Apr 5, 2022
@overheadhunter overheadhunter deleted the feature/check-vaultconfig-sig-during-key-recovery branch April 5, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate recovery key against vault config
2 participants