Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer binary stylesheets #2175

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Prefer binary stylesheets #2175

merged 3 commits into from
Apr 27, 2022

Conversation

overheadhunter
Copy link
Member

Compile our JavaFX themes into .bss files, which should load slightly faster.

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@infeo
Copy link
Member

infeo commented Apr 11, 2022

@overheadhunter Is there some sort of official documentation for this feature? I only found old posts about an javafxpackager.

@overheadhunter
Copy link
Member Author

Only in JavaDoc. The css2bin flag from javafxpackager has been dropped in jpackage, as "JavaFX-specific features" are declared non-goals in JEP 392.

Copy link
Member

@infeo infeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaDoc suffices me! Even thou the used Css2Bin class has no documentation, it just calls Stylesheet.convertToBinary(...).

@infeo infeo added this to the 1.6.9 milestone Apr 27, 2022
@infeo infeo merged commit fedb62d into develop Apr 27, 2022
@infeo infeo deleted the feature/binary-stylesheets branch April 27, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants