Implementation of issue #228

[jncharon]

Implementation of issue #228 : Add a confirmation message when removing a vault

[jncharon]

Oh it looks like this PR is on the wrong branch as it includes the code of the password strength meter. Can you redirect it to the right branch ?

[overheadhunter]

seems like it can not be changed. if it is still possible, can you isolate this specific feature (228) to be on a separate branch (without the pw meter)? this makes it easier to define the order in which features are merged into master.

[jncharon]

Hello Sebastian,

I closed the PR. I'd like to create a branch containing the code for #228
but it's commited in my master. And my master also contains the password
strength meter. Do you have any idea how I could extract the #228 code in a
new branch without the rest ?

Many thanks,
Jean-Noël

2016-04-22 23:11 GMT+02:00 Sebastian Stenzel notifications@github.com:

seems like it can not be changed. if it is still possible, can you isolate
this specific feature (228) to be on a separate branch (without the pw
meter)? this makes it easier to define the order in which features are
merged into master.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#246 (comment)

[overheadhunter]

I think this might work, if you apply this method for your latest two commits.

[jncharon]

It's ok I've got a branch set up and I'm ready to create a new pull
request. Shall I create it on upstream:master or will you create an
upstream branch for that ?

2016-04-23 11:06 GMT+02:00 Sebastian Stenzel notifications@github.com:

I think this
http://stackoverflow.com/questions/1628563/move-the-most-recent-commits-to-a-new-branch-with-git
might work, if you apply this method for your latest two commits.

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#246 (comment)

[overheadhunter]

@jncharon I just created a "delete-confirmation" branch.