Update check retry button & message #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck for updates upon startup
# Conflicts: # main/ant-kit/pom.xml # main/commons-test/pom.xml # main/commons/pom.xml # main/filesystem-api/pom.xml # main/filesystem-charsets/pom.xml # main/filesystem-crypto-integration-tests/pom.xml # main/filesystem-crypto/pom.xml # main/filesystem-inmemory/pom.xml # main/filesystem-invariants-tests/pom.xml # main/filesystem-nameshortening/pom.xml # main/filesystem-nio/pom.xml # main/filesystem-stats/pom.xml # main/frontend-api/pom.xml # main/frontend-webdav/pom.xml # main/jacoco-report/pom.xml # main/pom.xml # main/uber-jar/pom.xml # main/ui/pom.xml
# Conflicts: # main/ant-kit/pom.xml # main/commons-test/pom.xml # main/commons/pom.xml # main/filesystem-api/pom.xml # main/filesystem-charsets/pom.xml # main/filesystem-crypto-integration-tests/pom.xml # main/filesystem-crypto/pom.xml # main/filesystem-inmemory/pom.xml # main/filesystem-invariants-tests/pom.xml # main/filesystem-nameshortening/pom.xml # main/filesystem-nio/pom.xml # main/filesystem-stats/pom.xml # main/frontend-api/pom.xml # main/frontend-webdav/pom.xml # main/jacoco-report/pom.xml # main/pom.xml # main/uber-jar/pom.xml # main/ui/pom.xml
|
Changes Unknown when pulling 0520a53 on jncharon:develop into * on cryptomator:feature/update-check-retry*. |
| @@ -24,6 +24,14 @@ | |||
| <HBox alignment="CENTER" spacing="5.0" cacheShape="true" cache="true"> | |||
| <Label fx:id="checkForUpdatesStatus" cacheShape="true" cache="true" /> | |||
| <ProgressIndicator fx:id="checkForUpdatesIndicator" progress="-1" prefWidth="15.0" prefHeight="15.0" cacheShape="true" cache="true" cacheHint="SPEED" /> | |||
| <Label fx:id="checkForUpdatesErrorLabel" /> | |||
| <Button fx:id="checkForUpdatesRetryButton" cache="true" cacheShape="true" defaultButton="true" onAction="#executeCheckForUpdates" text="%welcome.checkForUpdates.retry"> | |||
| <graphic> | |||
There was a problem hiding this comment.
Don't use a png for this, we have imported the ionicons font for these purposes:
<graphic><Label text="" styleClass="ionicons"/></graphic>
|
Whats the deal with the |
|
All my pom.xml files had So they conflicted when I merged upstream/develop in origin/develop |
|
But why did you create a completely new pom.xml that is otherwise unrelated to the project? I think this is a mistake. I'm talking about the one in 0520a53. |
|
Ok I see the mistake. Please do the following:
|
|
I did not create poms, I guess intellij did ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update check retry button displayed if there's no internet connection