Improved Error Dialog

[mindmonk]

No description provided.

[infeo]

Goes in the right direction, but the code clarity can be improved.

[overheadhunter]

Either use the signum function or simply adjust the expectedResult to reflect the actual difference in upvote counts: This is not limited to just -1, 0 and 1 😄

[mindmonk]

Displayed view while loading:

Displayed view if solution was found:

Displayed view if no solution was found:

[overheadhunter]

Looks very good already. Just a couple of minor remarks (and maybe one bigger question: Can we remove "third level" error code sorting altogether?)

[overheadhunter]

these diffs are unrelated, i.e. please undo them

[mindmonk]

changes have been undone

[overheadhunter]

UI design is totally sufficient to get this merged, but I guess we can in a separate PR improve the visuals if a solution was found. CC @tobihagemann

[overheadhunter]

Ok, another suggestion for god level code legibility:

@DisplayName("compare error codes by root cause")
@ParameterizedTest(name = "{0} {1} {2}")
@CsvSource(textBlock = """
		Error 6HU1:12H1:0000, =, Error 6HU1:12H1:0000
		Error 6HU1:12H1:0007, =, Error 6HU1:12H1:0042
		Error 0000:0000:0000, =, Error 0000:0000:0000
		Error 6HU1:12H1:0000, <, Error 0000:0000:0000
		Error 6HU1:12H1:0000, <, Error 6HU1:0000:0000
		Error 0000:0000:0000, >, Error 6HU1:12H1:0000
		Error 6HU1:0000:0000, >, Error 6HU1:12H1:0000
		""")
public void testCompareSecondLevelMatch(String leftTitle, char expected, String rightTitle) {
	int expectedResult = switch (expected) {
		case '<' -> -1;
		case '>' -> +1;
		default -> 0;
	};
	// ...
}

[sschuberth]

BTW, as a user, I found it a bit disturbing to actually see the surrounding triple-backticks as part of the dialog. How about not showing them in the dialog, but adding them to the clipboard contents when clicking on Copy?

[sschuberth]

BTW, as a user, I found it a bit disturbing to actually see the surrounding triple-backticks as part of the dialog. How about not showing them in the dialog, but adding them to the clipboard contents when clicking on Copy?

See #2963.