Update Reminder #2998
Merged
Update Reminder #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infeo
requested changes
Jul 14, 2023
src/main/java/org/cryptomator/ui/updatereminder/UpdateReminderModule.java
Show resolved
Hide resolved
infeo
approved these changes
Jul 17, 2023
overheadhunter
requested changes
Jul 17, 2023
src/main/java/org/cryptomator/ui/fxapp/FxApplicationModule.java
Outdated
Show resolved
Hide resolved
overheadhunter
requested changes
Jul 17, 2023
src/main/java/org/cryptomator/ui/fxapp/FxApplicationModule.java
Outdated
Show resolved
Hide resolved
overheadhunter
approved these changes
Jul 20, 2023
This was referenced Sep 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #2984.
When the "Check for updates automatically" option is disabled in the Preferences, a dialog will be displayed upon application startup.
The "Not now" button sets the new setting value "lastUpdateCheck" to the current date. This ensures that the dialog will not be displayed again for 14 days.
The "Yes, Once" button also sets the current date in the setting value "lastUpdateCheck" and performs an update check.
The "Yes, Automatically" button sets the current date in the setting value "lastUpdateCheck" and also performs an update check. Additionally, this button sets the "checkForUpdates" value to true in the settings, which triggers an update check at every application startup.
Please refer to the attached screenshot for the added dialog.
Screenshot:
