Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: JDK22 #3435

Merged
merged 5 commits into from
May 21, 2024
Merged

Feature: JDK22 #3435

merged 5 commits into from
May 21, 2024

Conversation

infeo
Copy link
Member

@infeo infeo commented May 21, 2024

This PR updates the project to use/require JDK 22.

Fixes #3376 and #3382.

I did not remove the --enable-preview flag, since i'm not sure if we already use the String template processors somewhere.

@infeo infeo added this to the minor milestone May 21, 2024
@infeo infeo requested a review from overheadhunter May 21, 2024 13:45
@infeo infeo self-assigned this May 21, 2024
Copy link

coderabbitai bot commented May 21, 2024

Walkthrough

The recent updates primarily involve upgrading the Java version from 21 to 22 across multiple GitHub Actions workflow files. Additionally, the jdk.crypto.ec module has been removed from the build configurations, as its classes have been moved to java.base in the latest JDK.

Changes

Files Change Summaries
.github/workflows/appimage.yml, .github/workflows/mac-dmg.yml, .github/workflows/win-exe.yml Updated Java version to '22.0.1+8' and removed specific modules from build steps.
.github/workflows/build.yml, .github/workflows/dependency-check.yml, .github/workflows/get-version.yml, .github/workflows/pullrequest.yml, .github/workflows/release-check.yml Updated Java version from 21 to 22.
.github/workflows/check-jdk-updates.yml, .github/workflows/debian.yml Updated JDK version from '21.0.2+13' to '22.0.1+8' and related configurations.
.idea/misc.xml Changed languageLevel from JDK_21_PREVIEW to JDK_22.
src/main/java/module-info.java Removed requires jdk.crypto.ec; declaration.

Assessment against linked issues

Objective (Issue #3376) Addressed Explanation
Remove jdk.crypto.ec from build files

In the code's embrace, Java 22 takes flight,
Modules realigned, in the morning light.
No more jdk.crypto.ec to weigh us down,
Our builds are lighter, in every town.
With each command, we grow more bright,
Celebrating code, from day to night.

  • 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@overheadhunter overheadhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

@@ -23,7 +23,7 @@ on:

env:
JAVA_DIST: 'zulu'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope, but shouldn't we use the same JDK vendor for all our workflows?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the same JDK for all flows building release artifacts.

I think it is not necessary to stick to this rule for all workflows.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 863e9bb and 69bcf6f.
Files ignored due to path filters (6)
  • dist/linux/appimage/build.sh is excluded by !dist/**, !dist/**
  • dist/linux/debian/control is excluded by !dist/**, !dist/**
  • dist/linux/debian/rules is excluded by !dist/**, !dist/**
  • dist/mac/dmg/build.sh is excluded by !dist/**, !dist/**
  • dist/win/build.ps1 is excluded by !dist/**, !dist/**
  • pom.xml is excluded by !**/*.xml
Files selected for processing (12)
  • .github/workflows/appimage.yml (2 hunks)
  • .github/workflows/build.yml (1 hunks)
  • .github/workflows/check-jdk-updates.yml (1 hunks)
  • .github/workflows/debian.yml (1 hunks)
  • .github/workflows/dependency-check.yml (1 hunks)
  • .github/workflows/get-version.yml (1 hunks)
  • .github/workflows/mac-dmg.yml (2 hunks)
  • .github/workflows/pullrequest.yml (1 hunks)
  • .github/workflows/release-check.yml (1 hunks)
  • .github/workflows/win-exe.yml (2 hunks)
  • .idea/misc.xml (1 hunks)
  • src/main/java/module-info.java (1 hunks)
Files skipped from review due to trivial changes (10)
  • .github/workflows/build.yml
  • .github/workflows/check-jdk-updates.yml
  • .github/workflows/debian.yml
  • .github/workflows/dependency-check.yml
  • .github/workflows/get-version.yml
  • .github/workflows/mac-dmg.yml
  • .github/workflows/pullrequest.yml
  • .github/workflows/release-check.yml
  • .idea/misc.xml
  • src/main/java/module-info.java
Additional comments not posted (3)
.github/workflows/appimage.yml (2)

14-14: Updated Java version to '22.0.1+8' aligns with the PR's objective to upgrade to JDK 22.


83-83: Removal of jdk.crypto.ec from jlink command aligns with JDK 22 changes where this module is part of java.base.

.github/workflows/win-exe.yml (1)

19-19: Updated Java version to '22.0.1+8' aligns with the PR's objective to upgrade to JDK 22.

.github/workflows/win-exe.yml Show resolved Hide resolved
@infeo infeo merged commit 8c7dd8c into develop May 21, 2024
6 checks passed
@infeo infeo deleted the feature/jdk22 branch May 21, 2024 14:59
@infeo infeo mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove jdk.crypto.ec from build files
2 participants