Deprecate vault admin password #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are applicable through different group memberships
…-vault-admin-password
…ws to continue executing the filter chain
…-vault-admin-password # Conflicts: # backend/src/main/java/org/cryptomator/hub/entities/EffectiveVaultAccess.java
2 tasks
…-vault-admin-password
…-vault-admin-password # Conflicts: # backend/src/main/java/org/cryptomator/hub/api/VaultResource.java # frontend/src/components/GrantPermissionDialog.vue
…-vault-admin-password
* `PUT /{vaultId}/users/{userId}/?role=OWNER`
* `PUT /{vaultId}/groups/{groupId}/?role=OWNER`
(related to #214)
…-vault-admin-password # Conflicts: # backend/src/main/java/org/cryptomator/hub/api/VaultResource.java
…-vault-admin-password # Conflicts: # backend/src/main/java/org/cryptomator/hub/api/VaultResource.java [build image]
[build image]
…-vault-admin-password
…-vault-admin-password
…t/revoke ownership action [build image]
tobihagemann
force-pushed
the
feature/deprecate-vault-admin-password
branch
from
37149b8
to
0e92e29
Compare
…-vault-admin-password
…-vault-admin-password # Conflicts: # frontend/src/i18n/de-DE.json
overheadhunter
changed the base branch from
feature/refactored-access-grant
to
develop
# Conflicts: # backend/src/main/java/org/cryptomator/hub/api/VaultResource.java # backend/src/main/java/org/cryptomator/hub/entities/EffectiveVaultAccess.java # backend/src/main/java/org/cryptomator/hub/filters/VaultAdminOnlyFilterProvider.java # frontend/src/common/backend.ts # frontend/src/components/VaultDetails.vue
tobihagemann
requested changes
Sep 1, 2023
backend/src/main/java/org/cryptomator/hub/api/VaultResource.java
Outdated
Show resolved
Hide resolved
tobihagemann
requested changes
Sep 1, 2023
backend/src/main/java/org/cryptomator/hub/api/VaultResource.java
Outdated
Show resolved
Hide resolved
tobihagemann
approved these changes
Sep 6, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #209:
@VaultAdminOnlyFiltergot replaced by@VaultRole(VaultAccess.Role.OWNER).The UI will no longer ask for the Vault Admin Password when a user is the vault's owner.
Tasks
OWNERrole #210