Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset User Account #228

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Reset User Account #228

merged 2 commits into from
Oct 24, 2023

Conversation

overheadhunter
Copy link
Member

Fixes #208:

This deletes the user's key pair as well as devices. Furthermore all access tokens for the deleted key will be deleted.

@overheadhunter overheadhunter added this to the 1.3.0 milestone Oct 24, 2023
@overheadhunter
Copy link
Member Author

overheadhunter commented Oct 24, 2023

Note that deleting the browser key pair is probably dead code. If you think about the conditions when entering /app/setup:

browser key pair exists browser key pair missing
user key pair exists ✅ no setup required enter setup code, name new device
user key pair missing ❌ strange state create new user key pair

Technically, it is possible for a browser key pair to still exist if the account has been reset on a different device. However, the program logic would treat this the same as if the browser key did not exist and re-roll & overwrite it anyway, so there should be no need to ever delete it.

@tobihagemann tobihagemann changed the base branch from develop to feature/refactored-access-grant October 24, 2023 15:17
@tobihagemann tobihagemann changed the base branch from feature/refactored-access-grant to develop October 24, 2023 15:18
Copy link
Member

@tobihagemann tobihagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the "dead code". 👍

@tobihagemann tobihagemann merged commit 40871c5 into develop Oct 24, 2023
5 checks passed
@tobihagemann tobihagemann deleted the feature/reset-user-account branch October 24, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset User Account
2 participants