-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View users with their key fingerprint who should be granted permissions #235
Conversation
SailReal
commented
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm totally fine with this PR. But we should add some way for vault owners to verify these fingerprints with the users if they choose to.
As discussed, a user should be able to check their fingerprint. I believe the user profile would make most sense?
I guess this can be part of this PR. |
With the power of @JaniruTEC we now show the full fingerprint on hover: |
Since I am now officially part of this PR (😁), I have some minor ideas/suggestions:
|
This is just a very basic way to verify user fingerprint and will completely replaced by #191 in the next minor version so I would invest the time to enhance it into the replacing implementation.
I decided against it because there is not much place in this dialog especially because usernames often contains more characters like test1 if we have e.g. julian.raufelder@foo.bar.baz there isn't that much space left in this dialog.
This would require another variable that I wanted to avoid 😅
Where would you expect those words in this dialog? |
I'd expect them probably on hover, either over the aforementioned icon or over the short fingerprint. Something like:
IMO many users will have no idea what those cryptic numbers mean -- unless they make the connection to their own user fingerprint, which is something I wouldn't count on. |
Because of #190 and #191 we will rework this anyway. For now it is important, that the user is able to view and check the fingerprints in a way.
We should mention it in the docs at least. |