Last changes for Cryptomator Hub CLI #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps that the Hub CLI client does not need the admin role. Users can already search for users and can easily query all users using this endpoint.
overheadhunter
requested changes
Nov 13, 2023
backend/src/main/java/org/cryptomator/hub/api/GroupsResource.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/cryptomator/hub/api/VaultResource.java
Outdated
Show resolved
Hide resolved
overheadhunter
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides some changes for Cryptomator Hub CLI:
GET /vaults/some?ids=vaultId3000can now be executed asUSER, was beforeOWNERGroupsResourceto get all groups and of a group all effective users (including users of the subgroups)DELETE /{vaultId}/users/{userId}andDELETE /{vaultId}/groups/{groupId}is removed and replaced byDELETE /{vaultId}/authority/{authorityId}