Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen integrations-api to check whether keychain is locked #10

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Widen integrations-api to check whether keychain is locked #10

merged 2 commits into from
Feb 23, 2021

Conversation

purejava
Copy link
Contributor

infeo
infeo requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@infeo infeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny change. If this is done, the PR is good to go.

integrations-linux.iml Outdated Show resolved Hide resolved
@infeo
Copy link
Member

infeo commented Feb 22, 2021

I just noticed, that this PR also includes an updated kde-wallet dependency. For this change already PR #3 exists.

@purejava Contains kde wallet 1.2.0 any changes, that are necessary for the isLocked() mechanism?

@purejava
Copy link
Contributor Author

I just noticed, that this PR also includes an updated kde-wallet dependency. For this change already PR #3 exists.

@purejava Contains kde wallet 1.2.0 any changes, that are necessary for the isLocked() mechanism?

No, 1.2.0 does not have any changes that are needed for the isLocked() mechanism.
1.2.0 has an improved logging and new features. I thought it's alway best to go with the latest version but I can change that back to 1.1.1 of course.

@infeo
Copy link
Member

infeo commented Feb 23, 2021 •
edited

I thought it's alway best to go with the latest version but I can change that back to 1.1.1 of course.

While generally i would also favor that, in this case the version bump contains bigger changes which needed to be looked at and tested (...again^^ the last time i looked at it is already a while ago)

@infeo infeo merged commit 6d9f914 into cryptomator:develop Feb 23, 2021
@infeo infeo self-assigned this Feb 23, 2021
@infeo infeo added the enhancement New feature or request label Feb 23, 2021
@purejava purejava deleted the keychain-isLocked branch February 27, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infeo infeo infeo approved these changes

Assignees

@infeo infeo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User prompted by Gnome Keyring / KDE Wallet when clicking on "Unlock..."
2 participants
@purejava @infeo