Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kdewallet to 1.3.1 #23

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

purejava
Copy link
Contributor

This updates kdewallet to the current version and re-enables the kdewallet functionality in integrations-linux.

As the 'split jar' problem arose for the first time, I released kdewallet 1.3.0 to fix it, but with it, not all classes of kdewallet were moved to a namespace controlled by the author, as the package name of the Java interface needs to follow the interface name of the D-Bus interface. By using @DBusInterfaceName, all interfaces can be moved to a namespace controlled by the author and thus fully avoid 'split jar' problems. This is done with kdewallet 1.3.1.

Implementing the libappindicator features for integrations-linux made it necessary to have a module-info.java. It currently lacks a KeychainAccessProvider for kdewallet to make kdewallet functionality available for Cryptomator.

Both problems are addressed with this PR.

Provide a KeychainAccessProvider for kdewallet as well
@infeo infeo self-assigned this Jun 19, 2023
@infeo infeo merged commit 24db1e9 into cryptomator:develop Jun 19, 2023
3 checks passed
@purejava purejava deleted the kdewallet-update branch June 19, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants