Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kdewallet to 1.3.2 #25

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Update kdewallet to 1.3.2 #25

merged 1 commit into from
Jul 26, 2023

Conversation

purejava
Copy link
Contributor

Closes cryptomator/cryptomator#3020.

Up to version 1.3.1 of kdewallet, the code contains a shutdown hook, that gets triggered on shutdown of the JVM and performs a clean-up.

This clean-up unregisters the D-Bus signals relevant for and registered to kdewallet.

Nevertheless, the clean-up can fail when the D-Bus connection is already closed.

Furthermore, the clean-up is not needed, as dbus-java does the clean-up.

This PR updates the dependency to kdewallet 1.3.2, where the shutdown hook and the clean-up were removed.

@infeo infeo merged commit 85db5c7 into cryptomator:develop Jul 26, 2023
3 checks passed
@infeo
Copy link
Member

infeo commented Jul 26, 2023

Thanks, @purejava!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App shutdown delayed
2 participants