Skip to content

Commit

Permalink
Merge branch 'release/2.4.3'
Browse files Browse the repository at this point in the history
  • Loading branch information
tobihagemann committed Dec 6, 2022
2 parents acb500f + 2853931 commit 731ab63
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 20 deletions.
4 changes: 2 additions & 2 deletions Cryptomator.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3254,7 +3254,7 @@
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MARKETING_VERSION = 2.4.2;
MARKETING_VERSION = 2.4.3;
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES;
ONLY_ACTIVE_ARCH = YES;
Expand Down Expand Up @@ -3316,7 +3316,7 @@
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MARKETING_VERSION = 2.4.2;
MARKETING_VERSION = 2.4.3;
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
OTHER_SWIFT_FLAGS = "-Xfrontend -warn-long-expression-type-checking=200 -Xfrontend -warn-long-function-bodies=200";
Expand Down
15 changes: 13 additions & 2 deletions Cryptomator/S3/S3AuthenticationViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ import CryptomatorCommonCore
import SwiftUI
import UIKit

class S3AuthenticationViewController: UIHostingController<S3AuthenticationView> {
class S3AuthenticationViewController: UIViewController {
weak var coordinator: (Coordinator & S3Authenticating)?
let viewModel: S3AuthenticationViewModel
private var subscriptions = Set<AnyCancellable>()

init(viewModel: S3AuthenticationViewModel) {
self.viewModel = viewModel
super.init(rootView: S3AuthenticationView(viewModel: viewModel))
super.init(nibName: nil, bundle: nil)
}

@available(*, unavailable)
Expand All @@ -28,6 +28,8 @@ class S3AuthenticationViewController: UIHostingController<S3AuthenticationView>

override func viewDidLoad() {
super.viewDidLoad()
setupSwiftUIView()

let doneButton = UIBarButtonItem(barButtonSystemItem: .done, target: self, action: #selector(done))
navigationItem.rightBarButtonItem = doneButton
let cancelButton = UIBarButtonItem(barButtonSystemItem: .cancel, target: self, action: #selector(cancel))
Expand Down Expand Up @@ -64,4 +66,13 @@ class S3AuthenticationViewController: UIHostingController<S3AuthenticationView>
@objc func cancel() {
coordinator?.cancel()
}

private func setupSwiftUIView() {
let child = UIHostingController(rootView: S3AuthenticationView(viewModel: viewModel))
addChild(child)
view.addSubview(child.view)
child.didMove(toParent: self)
child.view.translatesAutoresizingMaskIntoConstraints = false
NSLayoutConstraint.activate(child.view.constraints(equalTo: view))
}
}
2 changes: 1 addition & 1 deletion Cryptomator/WebDAV/WebDAVAuthentication.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ struct WebDAVAuthentication: View {
@FocusStateLegacy private var focusedField: Fields? = .url

var body: some View {
List {
Form {
TextField(LocalizedString.getValue("common.cells.url"), text: $viewModel.url)
.keyboardType(.URL)
.disableAutocorrection(true)
Expand Down
17 changes: 14 additions & 3 deletions Cryptomator/WebDAV/WebDAVAuthenticationViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ import Promises
import SwiftUI
import UIKit

class WebDAVAuthenticationViewController: UIHostingController<WebDAVAuthentication> {
class WebDAVAuthenticationViewController: UIViewController {
weak var coordinator: (Coordinator & WebDAVAuthenticating)?
private var viewModel: WebDAVAuthenticationViewModel
private let viewModel: WebDAVAuthenticationViewModel
private var cancellables = Set<AnyCancellable>()
private var hud: ProgressHUD?

init(viewModel: WebDAVAuthenticationViewModel) {
self.viewModel = viewModel
super.init(rootView: WebDAVAuthentication(viewModel: viewModel))
super.init(nibName: nil, bundle: nil)
}

@available(*, unavailable)
Expand All @@ -31,6 +31,8 @@ class WebDAVAuthenticationViewController: UIHostingController<WebDAVAuthenticati

override func viewDidLoad() {
super.viewDidLoad()
setupSwiftUIView()

title = "WebDAV"
let cancelButton = UIBarButtonItem(barButtonSystemItem: .cancel, target: self, action: #selector(cancel))
navigationItem.leftBarButtonItem = cancelButton
Expand Down Expand Up @@ -87,6 +89,15 @@ class WebDAVAuthenticationViewController: UIHostingController<WebDAVAuthenticati
@objc func cancel() {
coordinator?.cancel()
}

private func setupSwiftUIView() {
let child = UIHostingController(rootView: WebDAVAuthentication(viewModel: viewModel))
addChild(child)
view.addSubview(child.view)
child.didMove(toParent: self)
child.view.translatesAutoresizingMaskIntoConstraints = false
NSLayoutConstraint.activate(child.view.constraints(equalTo: view))
}
}

#if DEBUG
Expand Down
5 changes: 1 addition & 4 deletions fastlane/changelog.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
- Added possibility to edit WebDAV connections (#256)
- Added Danish translation
- Fixed missing files when encrypted files are offloaded in iCloud Drive (#279)
- Fixed flickering when vault list is empty (#257)
- Fixed missing buttons when adding WebDAV/S3 connections on iOS 13/14 (#280, #282)
5 changes: 1 addition & 4 deletions fastlane/metadata/de-DE/release_notes.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
- Möglichkeit zum Bearbeiten von WebDAV-Verbindungen hinzugefügt (#256)
- Dänische Übersetzung hinzugefügt
- Fehlende Dateien behoben, wenn verschlüsselte Dateien in iCloud Drive nicht lokal vorliegen (#279)
- Flackern behoben, wenn die Tresorliste leer ist (#257)
- Fehlende Buttons beim Hinzufügen von WebDAV/S3-Verbindungen unter iOS 13/14 behoben (#280, #282)
5 changes: 1 addition & 4 deletions fastlane/metadata/en-US/release_notes.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
- Added possibility to edit WebDAV connections (#256)
- Added Danish translation
- Fixed missing files when encrypted files are offloaded in iCloud Drive (#279)
- Fixed flickering when vault list is empty (#257)
- Fixed missing buttons when adding WebDAV/S3 connections on iOS 13/14 (#280, #282)

0 comments on commit 731ab63

Please sign in to comment.