Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow certain special characters in filenames #152

Closed
2 tasks done
arya-coding opened this issue Jan 13, 2022 · 5 comments · Fixed by #157
Closed
2 tasks done

Disallow certain special characters in filenames #152

arya-coding opened this issue Jan 13, 2022 · 5 comments · Fixed by #157
Labels
type:bug Something isn't working
Milestone

Comments

@arya-coding
Copy link

Please agree to the following

Summary

Renaming folder on IOS with character "/" broke the vault on Windows

System Setup

  • iOS: 2.0.0 (722)
  • Cryptomator: 1.6.3 (Then updated to 1.6.5, problem persist)

Cloud Type

WebDAV

Steps to Reproduce

  1. Authenticate and unlock the vault of Cryptomator on IOS File App
  2. Rename a folder by adding the character "/" in the name
  3. Unlock the vault on Windows with Cryptomator
  4. The folder appear on Windows with the character ":" instead of "/"
  5. Windows cannot create any folder inside this renamed folder. the following error comes up "new folder error 0x8000ffff catastrophic failure"
  6. I can list the files but I cannot access any file within that renamed folder on Windows but on IOS everything works fine.
  7. I tried to duplicate the folder on IOS File App
  8. The folder appears again with ":" character instead of "/" on his name on Windows, on IOS it's working fine. I have the same problem on Windows, cannot edit anything within the folder.
  9. I created an other folder with a different name (without "/" character) on IOS Files within the Cryptomator Vault
  10. Tried to copy the broken folder content to the new created one (Failed because of pCloud WEBDAV performances)
  11. Now the root folder of the renamed folders appears to be empty on Windows. (Tried locking the vault, closing Cryptomator, reboot, ...)
  12. The root folder is still accessible and all his files only on IOS File Apps

Expected Behavior

  • The renamed folder should include the character "/" and not ":"
  • The folder on Windows should be accessible in read/write

Actual Behavior

  • First blocking Read and Write on Windows
  • Then showing the root folder of the main one as empty

Reproducibility

Only once

Relevant Log Output

No response

Anything else?

No response

@arya-coding arya-coding added the type:bug Something isn't working label Jan 13, 2022
@tobihagemann tobihagemann changed the title Cryptomator 2 IOS and Cryptomator 1.6.3 Windows Disallow certain special characters in filenames Jan 13, 2022
@tobihagemann tobihagemann added this to the 2.1.0 milestone Jan 13, 2022
@tobihagemann
Copy link
Member

You're right, we should disallow certain special characters for filenames, which we're already doing for the vault name.

Workaround: Rename the affected files on iOS to something else without the special characters.

@arya-coding
Copy link
Author

arya-coding commented Jan 13, 2022

Yes I mean naming a folder with "/" knowing that it would work cross platform isn't the best idea I had but ... (Even if the OS supports this characters)

Unfortunately now the workaround is too late as the problem evolved to show me an empty root folder. Do you have any leads to help me to solve that please ?

Because the only way to solve this now is to copy/paste each file in a new folder through IOS File App (not even whole folders cause Webdav pCloud works as a timeout request factory) and I have hundreds of files in this specific folder.

@tobihagemann
Copy link
Member

I don't quite understand the situation. Can't you rename the folder with "/" on iOS to something different? What happens if you try that?

@arya-coding
Copy link
Author

Yes the root folder of the renamed folder still appears empty on Windows.

It's okay, I solved it by

  1. Downloading the vault on my linux
  2. Unlocking the vault
  3. Extracted the files from the corrupted root folder that appears empty on Windows
  4. Deleted the folder on Linux
  5. Created the folder again with the good correct subfolder names (avoiding "/" character")

Thank you Tobias

@tobihagemann
Copy link
Member

tobihagemann commented Jan 14, 2022

I must admit that I'm surprised that renaming the folder didn't work. 🤔 But I'm glad that you've found a different solution.

I'm reopening this issue because we'd still like to disallow these special characters. We'll close it after fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants