Bugfix: Fix iOS 14 SwiftUI HostingViewController missing Navigation Items #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as `viewDidLoad` gets not called for a UIHostingController on iOS 14.
tobihagemann
approved these changes
Dec 6, 2022
tobihagemann
deleted the
bugfix/fix_ios14_swiftui_hostingviewcontroller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS 14
viewDidLoadgets not called when subclassingHostingViewController.As we used the
viewDidLoadfor setting the title, navigationItems and setting up the bindings this leads to errors (see #280).This PR fixes these problems and thus closes #280 by using a standard
UIViewControllerand just embed the view of theHostingViewController.Furthermore, the appearance of the
WebDAVAuthenticationScreen has been updated for iOS 14 to be alsoinsetGrouped.