Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI for batch CIDs #45

Closed
0xjona opened this issue Jun 11, 2022 · 6 comments
Closed

CLI for batch CIDs #45

0xjona opened this issue Jun 11, 2022 · 6 comments

Comments

@0xjona
Copy link
Collaborator

0xjona commented Jun 11, 2022

Improvement of #12

soon to be discussed ti define design docs

@turinglabsorg
Copy link
Collaborator

Going a little bit deeper on that, there's one thing we have discussed yesterday with @irenegia. Since this is not a pinning service, any provider should pin cids outside our CLI. So we should start thinking how providers will really use our service, since there's no actual pinning done by the code.

One idea can be create an endpoint that exports all the CIDs that's supposed to be pinned by the provider.

What do you think @irenegia @nicola?

@irenegia
Copy link
Collaborator

So, with adding the

endpoint that exports all the CIDs that's supposed to be pinned by the provider.

now for every deal proposal accepted by a provider our protocol will guarantee that the files corresponding to the CID in the deal are pin (saved) to some IPFS node somewhere. Correct?

I like the idea, with this the name "retrieval pinning" would be the perfect one.
But,

  • with this change we will depend on the IPFS pinning service we choose, right? Are we okay with this @nicola?
    Note that we already have this dependency today to create a CID and to retrieve a file...

  • Does this require the client always uploading the file? Or can we maintain the flexibility that we have now where deal proposal can also be done just about a CID, without any upload required? In other words, do we keep the possibility of "I can make a deal about a file I don't directly have"?

@turinglabsorg
Copy link
Collaborator

now for every deal proposal accepted by a provider our protocol will guarantee that the files corresponding to the CID in the deal are pin (saved) to some IPFS node somewhere. Correct?

I'm not sure it's correct to say "protocol will guarantee", because it's the provider that guarantees by putting some money on the table. The provider guarantees that the file will be publicly available at a specific endpoint (thing we talked about yesterday) and the protocol guarantees that money are returned to the client if provider lies.

So at the end of the day it's the provider that should pin in one (or several) IPFS nodes using the method he prefers, important thing is that the file will be available if referees are invoked by the client.

with this change we will depend on the IPFS pinning service we choose, right? Are we okay with this @nicola?
Note that we already have this dependency today to create a CID and to retrieve a file...

This is likely more an upgrade not a change, we don't need any pinning service at the moment (as protocol).

Does this require the client always uploading the file? Or can we maintain the flexibility that we have now where deal proposal can also be done just about a CID, without any upload required? In other words, do we keep the possibility of "I can make a deal about a file I don't directly have"?

Deals can be written directly on-chain by writing the CID, the upload part it's used to actually calculate the CID. File is not retained in any pinning service. So yes, you can create a deal for a file you don't directly have :-)

@nicola
Copy link

nicola commented Jun 27, 2022

Agree with @turinglabsorg

The smart contract does not care how the delivery of the data behind a CID happened.

@turinglabsorg
Copy link
Collaborator

@0xjona this can be closed because it's part of the second epic (Provider UX - Software upgrades).

@0xjona
Copy link
Collaborator Author

0xjona commented Jul 12, 2022

#67 yes

@0xjona 0xjona closed this as completed Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants