New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test import keys with as many as 130k keys #319
Comments
The worker thread is best for this task. I'll leave the old non-worker route accessible incase someone with a smaller wallet can not fully support the functions within the worker thread. For example, indexedDb and worker threads were only recently fixed in FF: https://bugzilla.mozilla.org/show_bug.cgi?id=701634 |
So far it is working well wile avoiding database writes in worker threads. Keeping the threads on ram only will avoid compatibility issues (like the note above) and consistency complexity (worker threads operate in their own memory space). |
I have had some success using worker threads using them for only the safest operations. It is not possible to utilize them fully as FF does not support worker threads as well as Chrome. I suspect Safari will have the same issues (so I did not use those features). Basically, you may be able to import a wallet with 130K keys, however, the experience will not be pleasant and the work-load will effect backups. We could really use a method for filtering the keys. |
Filtering may be applied so we can obtain a reasonable import and backup sizes. This may be done in (a) a new bitshares_client release (BTS 0.9.4 for example) or (b) may be applied over the network. Network filtering does depend on a fix for this issue in the witness_node: cryptonomex/graphene#324 |
In the UI import keys, I will detect large wallet import files and offer to apply bloom.dat to filter them. I can show something like this: "This is a very large key file and will cause known performance problems. Would you like to filter this import to include only keys and addresses used in the genesis release block of BitShares 2.0? You will have a chance to preview and check your balances. We recommend you save your original key file as it contains all your keys." |
A testrun deployment to https://bitshares.org/worker is scheduled. |
https://bitsharestalk.org/index.php/topic,18401.msg243421.html#msg243421
The text was updated successfully, but these errors were encountered: