Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pay fees in BTS if possible #356

Closed
bytemaster opened this issue Oct 20, 2015 · 8 comments
Closed

Add option to pay fees in BTS if possible #356

bytemaster opened this issue Oct 20, 2015 · 8 comments
Assignees
Milestone

Comments

@bytemaster
Copy link
Contributor

On the settings page there should be a "preferred fee paying asset" that defaults to CORE.

On the transfer page, add selector that allows the user to select which asset type they want to pay the fees in.

@wmbutler
Copy link
Contributor

wmbutler commented Nov 5, 2015

screen shot 2015-11-05 at 2 42 08 pm

@wmbutler wmbutler added this to the 2.0.151118 milestone Nov 5, 2015
@wmbutler
Copy link
Contributor

wmbutler commented Nov 5, 2015

And this is a concept for the payment screen. I think it's nice for the user to always see the fee they pay regardless of the chosen asset. The dropdown would display BTS if CORE is the default and another asset if that the default is something else. The user would not be allowed to change the value in the input field, but the value would dynamically change based upon the asset chosen from the dropdown.

screen shot 2015-11-05 at 3 04 03 pm

@wmbutler
Copy link
Contributor

@svk31 You think this will be worked in this Milestone or pushed to 1125? Seems like your area of expertise.

@svk31
Copy link
Contributor

svk31 commented Nov 19, 2015

This is @jcalfee's domain really, he's the one behind all the transaction processing. I could have a look but I'm worried I might break something.

There's a related issue here: market trading fees. They're currently paid in whatever asset you're selling, which means a bid in the USD:BTS market has fees in BTS, while an ask has fees in USD.

Would it be preferable to always pay fees in BTS, or always in USD (or whatever the quote asset is)?

@wmbutler
Copy link
Contributor

@jcalfee bumping this to you based upon @svk31 comment above. @bytemaster since you opened this, can you chime in on the fees question above. I expect you have an opinion on this.

@wmbutler
Copy link
Contributor

@jcalfee Will you be able to commit to this in 1202 or does it need to get pushed further out?

@abitmore
Copy link
Contributor

Wouldn't we'll have the feature "pay by receiver"? It's conflict to this issue.

@svk31 svk31 assigned svk31 and unassigned jcalfee Dec 2, 2015
@svk31
Copy link
Contributor

svk31 commented Dec 2, 2015

I've added the fees selector, it lets you choose any asset for which you have a positive balance to pay the fees with. Changing the asset type to send will automatically set the fee to be in that asset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants