Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database_fixture is ripe for refactoring #11

Closed
vikramrajkumar opened this issue Jun 9, 2015 · 1 comment
Closed

database_fixture is ripe for refactoring #11

vikramrajkumar opened this issue Jun 9, 2015 · 1 comment
Labels

Comments

@vikramrajkumar
Copy link
Contributor

Here are the problems with database_fixture:

  • Reliance on macros makes single stepping through tests difficult with GDB.
  • "trx" object being modified by macros makes it effectively a global variable. Functions / macros use trx for both input and output.
  • Many methods in .hpp could be moved to .cpp file, speed compiling, iterative development of new database_fixture method doesn't need to recompile every test .cpp file (as long as signature in header doesn't change)
  • Poor naming conventions in some places (e.g. genesis_account should be genesis_account_id)
@vikramrajkumar
Copy link
Contributor Author

This issue was moved to bitshares/bitshares-core#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants