Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

witness_update operation needs tested #258

Closed
theoreticalbts opened this issue Aug 20, 2015 · 3 comments
Closed

witness_update operation needs tested #258

theoreticalbts opened this issue Aug 20, 2015 · 3 comments
Labels
needs testing
Milestone
DevShares 2.0

Comments

@theoreticalbts
Copy link
Contributor

We need a witness_update_operation to be able to update block_signing_key and url field of a witness object.

Setting the block_signing_key to zero should not be allowed (this will be reserved for when/if we implement witness resignation). There should also be a memo field in the operation which contains the secret, encrypted to the new signing key. The memo field should be vector<char>.
@vikramrajkumar vikramrajkumar added this to the DevShares 2.0 milestone Aug 21, 2015
@theoreticalbts
Copy link
Contributor Author

Committee members are in the same situation: They have a url field which can never be updated.

theoreticalbts added a commit that referenced this issue Aug 26, 2015
@theoreticalbts
Implement witness_update_operation #258
7db477b
theoreticalbts added a commit that referenced this issue Aug 26, 2015
@theoreticalbts
Implement committee_member_update operation #258
695978c
@theoreticalbts
Copy link
Contributor Author

These ops need unit tests.

@theoreticalbts theoreticalbts changed the title witness_update operation is unimplemented witness_update operation needs tested Feb 3, 2016
@vikramrajkumar vikramrajkumar mentioned this issue Jan 17, 2017
Closed
@vikramrajkumar
Copy link
Contributor

This issue was moved to bitshares/bitshares-core#70

pmconrad pushed a commit to pmconrad/graphene that referenced this issue May 24, 2017
@abitmore
Fix account_history filtering by account cryptonomex#258
a4a8b67
pmconrad pushed a commit to pmconrad/graphene that referenced this issue May 24, 2017
@vikramrajkumar
Merge pull request cryptonomex#259 from bitshares/258-account-history…
8a44c6a 
…-filter-fix

Fix account_history filtering by account cryptonomex#258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs testing
Projects
None yet
Milestone
DevShares 2.0
Development

No branches or pull requests
2 participants
@vikramrajkumar @theoreticalbts