Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to annual member doesn't set upgrading account's own referrer #455

Closed
theoreticalbts opened this issue Nov 20, 2015 · 2 comments
Closed

Upgrading to annual member doesn't set upgrading account's own referrer #455

theoreticalbts opened this issue Nov 20, 2015 · 2 comments
Assignees
@bytemaster
Labels
awaiting review needs testing
Milestone
next

Comments

@theoreticalbts
Copy link
Contributor

Account's referrer should be set here but it is not.

We should have a test case to prove this.
@theoreticalbts
Copy link
Contributor Author

Also need to test that the referrer is reset correctly when membership expires. NB resetting is lazy (i.e. only reset when annual member would have gotten additional fees).

theoreticalbts added a commit that referenced this issue Nov 20, 2015
@theoreticalbts
account_evaluator.cpp: Set annual referrer to self when upgrading to …
498ebf4 
…annual member #455
@theoreticalbts
Copy link
Contributor Author

Lucky us, we can still sync with the above patch. Very similar to #453 : None of the incorrectly allocated funds have been withdrawn from their VBO, so we can simply reinterpret the history to compute the balances correctly without invalidating any tx's.

This was referenced Nov 20, 2015
Closed
Closed
@theoreticalbts theoreticalbts added this to the next milestone Nov 23, 2015
@theoreticalbts theoreticalbts mentioned this issue Feb 3, 2016
Closed
@vikramrajkumar vikramrajkumar mentioned this issue Jan 17, 2017
Closed
pmconrad pushed a commit to pmconrad/graphene that referenced this issue Dec 22, 2017
@abitmore
Merge pull request cryptonomex#455 from abitmore/449-fill-order-price
70c2c83 
Store price in fill_order_operation, for cryptonomex#449.
Also addressed a few other issues related to market history plugin and API, e.g. cryptonomex#448.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bytemaster bytemaster

Labels
awaiting review needs testing
Projects
None yet
Milestone
next
Development

No branches or pull requests
2 participants
@bytemaster @theoreticalbts