Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hardfork.hpp autogenerated from hardforks.d directory #511

Closed
theoreticalbts opened this issue Jan 8, 2016 · 2 comments
Closed

Make hardfork.hpp autogenerated from hardforks.d directory #511

theoreticalbts opened this issue Jan 8, 2016 · 2 comments
Assignees
Milestone

Comments

@theoreticalbts
Copy link
Contributor

There are always a ton of merge conflicts in hardfork.hpp so we should make it auto-generated from a directory of files, each containing one line. Combine these files with find hardforks.d -name "*.hf" | sort | xargs cat > hardfork.hpp but for cross-platform building purposes we need to implement the shell one-liner in a cross-platform way.

@theoreticalbts theoreticalbts self-assigned this Jan 8, 2016
@theoreticalbts theoreticalbts added this to the next2 milestone Jan 8, 2016
@theoreticalbts
Copy link
Contributor Author

I was thinking we'd have to write a C++ program for the shell one-liner, but it turns out cmake is powerful enough to sort and concatenate a list of files.

@theoreticalbts
Copy link
Contributor Author

Implemented.

abitmore referenced this issue in abitmore/bitshares-core Jan 15, 2016
Generate hardfork.hpp from hardfork.d directory bitshares#511
pmconrad pushed a commit to pmconrad/graphene that referenced this issue Mar 11, 2018
pmconrad pushed a commit to pmconrad/graphene that referenced this issue Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant