Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer something-for-nothing culling for taker orders until the order is unmatched #555

Closed
theoreticalbts opened this issue Feb 5, 2016 · 3 comments
Assignees
Milestone

Comments

@theoreticalbts
Copy link
Contributor

The code here culls orders which would allow a counterparty to get something for nothing due to rounding. However, if the order being culled is a taker order, this culling should be deferred until the taker order doesn't match (and any unfilled remnant would become a maker order).

Put another way, the culling is currently being applied to taker orders, and it really only makes sense to apply it for maker orders.

As the order issued by the buyback code under development for #538 is a taker order with a very small price, correctly handling this case is a prerequisite for that feature.

@theoreticalbts theoreticalbts added this to the next2 milestone Feb 5, 2016
@theoreticalbts theoreticalbts self-assigned this Feb 5, 2016
@abitmore
Copy link
Contributor

abitmore commented Feb 6, 2016

I wonder if cancel_order will cause a fee to the owner with that code.

@theoreticalbts
Copy link
Contributor Author

The deferred_fee is taken off the order, and any market fee is charged, but it shouldn't charge the cancellation fee as other cancel ops, as this code uses push_applied_operation. The idea being that the order being almost-totally filled is (economically) the same as the order being totally filled, and it doesn't need to be charged a cancellation fee.

@theoreticalbts theoreticalbts changed the title Defer something-for-nothing culling for taker orders except when market is full Defer something-for-nothing culling for taker orders until the order is unmatched Feb 8, 2016
@theoreticalbts
Copy link
Contributor Author

Implemented, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants