Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_account_history may terminate early due to using first op as sentinel value #578

Closed
theoreticalbts opened this issue Feb 15, 2016 · 1 comment

Comments

@theoreticalbts
Copy link
Contributor

Calling get_account_history on the account which owns get_object 1.11.0 may cause the iteration to stop early because of a confusion between two cases:

  • Case 1: There is no next operation_history_object, we have reached the end of the list
  • Case 2: The next operation_history_object exists and has ID zero

The simple fix for new chains is to create a dummy sentinel operation_history_object with ID zero. However, this fix will not work on already-deployed chains because it will change history ID's.

A deployable fix would append 1.11.0 to its result when:

  • The account for which the operation history is being requested is the account for 1.11.0
  • Appending it would not exceed the request limits
@vikramrajkumar
Copy link
Contributor

This issue was moved to bitshares/bitshares-core#168

pmconrad pushed a commit to pmconrad/graphene that referenced this issue Mar 11, 2018
Capture exceptions when initializing `vote_id_type` with a string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants