Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect baker data in accounts #324

Closed
4 tasks
vishakh opened this issue Sep 29, 2020 · 1 comment
Closed
4 tasks

Fix incorrect baker data in accounts #324

vishakh opened this issue Sep 29, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@vishakh
Copy link
Contributor

vishakh commented Sep 29, 2020

Problem: The Tezos RPC call ../votes/listings is used to fetch the number of baker rolls and, ultimately, set baker status in the accounts tables. This RPC call returns no results for certain phases of governance like testing. This might have always been a bug or triggered by some relatively recent change in node behavior. Due to this, the accounts table shows incorrect data for is_baker in the accounts table.

Fixes:

  • Change the logic for setting is_baker in the accounts tables to check the bakers table for a valid record.
  • To set the 'rolls' value in the bakers tables, diving the 'staking_balance' field by a constant configured to 8,000.

Validation:

  • For any well-known baker, there should be valid data in the accounts tables through all four cycles of governance.
  • The new rolls values should match the value returned by the ../votes/listings RPC route for the proposal governance period.
@vishakh vishakh added the bug Something isn't working label Sep 29, 2020
@vishakh
Copy link
Contributor Author

vishakh commented Sep 29, 2020

Wrong project.

@vishakh vishakh closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants