Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundencies in TezosOperations module #53

Closed
vishakh opened this issue Oct 27, 2018 · 1 comment
Closed

Remove redundencies in TezosOperations module #53

vishakh opened this issue Oct 27, 2018 · 1 comment
Assignees
@anonymoussprocket
Labels
enhancement New feature or request

Comments

@vishakh
Copy link
Contributor

vishakh commented Oct 27, 2018

sendTransactionOperation(), sendDelegationOperation() and sendOriginationOperation() are not following the DRY principle and should be refactored so the operation payloads are not duplicated several times.
@vishakh vishakh added the enhancement New feature or request label Oct 27, 2018
ba205 added a commit that referenced this issue Oct 29, 2018
@ba205
Addressed #53, refactored TezosOperations, also created Operation int…
f3a101d 
…erface to generalize Transactions, Delegations, and Originations for refactoring
@ba205 ba205 mentioned this issue Oct 29, 2018
Merged
@ba205 ba205 mentioned this issue Nov 6, 2018
Merged
@anonymoussprocket
Copy link
Contributor

outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anonymoussprocket anonymoussprocket

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vishakh @ba205 @anonymoussprocket