Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

Cannot move text that have url links #16

Closed
ghost opened this issue May 15, 2019 · 1 comment
Closed

Cannot move text that have url links #16

ghost opened this issue May 15, 2019 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented May 15, 2019

Steps:

  • Create a text with a url link
  • Place it
  • Move it

Expected Result:

Text is moved

Actual Result:

You get navigated to the link instantly without prompt and you lose your previous edits

Workaround:

Remove link from text before moving it.
Move it
Add link back

@ghost ghost added the bug Something isn't working label Jun 5, 2019
@ghost ghost modified the milestones: v1, v2 Jun 13, 2019
@bnolan
Copy link
Contributor

bnolan commented Jul 8, 2019

Fixed, thanks!

+++ b/src/tools/feature.ts
@@ -162,6 +162,8 @@ export default class Selector {
 
   editFeature () {
     if (this.nextMode === FeatureSelectionMode.Move) {
+      this.ui.controls.clickNerf()
+      
       this.deactivate()
 
       setTimeout(() => {
@@ -217,6 +219,8 @@ export default class Selector {
 
     feature.regenerate()
     feature.save()
+
+    this.ui.controls.clickNerf()
   }

@bnolan bnolan closed this as completed Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant