Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning required on /admin/#stats #1176

Closed
ghost opened this issue Aug 8, 2023 · 0 comments
Closed

Warning required on /admin/#stats #1176

ghost opened this issue Aug 8, 2023 · 0 comments
Labels
Junior friendly Something that should be quick and/or easy to fix Performance Resources efficience UI/UX Interfaces & user experience
Milestone

Comments

@ghost
Copy link

ghost commented Aug 8, 2023

Description

The Disk usage functionality is a convenient way to analyze how CryptPad is using the server's storage. However, when it's using a lot of space, clicking the "Generate report" button can lead to consuming all the memory available on the machine. Having the CryptPad process running out of memory and crashing.

We should add a short warning message when clicking the button explaining this and asking for confirmation.

This could be something like this:

Depending on the size of the data stored on your instance, generating this report can consume all the memory available on your server and lead to a crash. Use with caution!

Steps to reproduce

  1. Head over /admin/#stats
  2. Scroll down the page
  3. Click "Generate report"
  4. Have your instance crashing

Relevant logs

No response

Expected behavior

A warning message should be displayed after the first click, with a button asking for confirmation.

What opreating system are you using?

Apple macOS

What browsers are you seeing the problem on?

Mozilla Firefox

Extensions

uBlock origin, Wappalyzer, Passbolt

Version

5.4-rc

@ghost ghost added Performance Resources efficience Junior friendly Something that should be quick and/or easy to fix UI/UX Interfaces & user experience labels Aug 8, 2023
@ghost ghost added this to the 5.5.0 milestone Sep 6, 2023
@yflory yflory added the Fixed in staging This is live on staging branch label Sep 26, 2023
@davidbenque davidbenque removed the Fixed in staging This is live on staging branch label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Junior friendly Something that should be quick and/or easy to fix Performance Resources efficience UI/UX Interfaces & user experience
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants