Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of large attachment button is inconsistent in Forms app #1237

Closed
2 tasks
davidbenque opened this issue Sep 7, 2023 · 0 comments
Closed
2 tasks

Display of large attachment button is inconsistent in Forms app #1237

davidbenque opened this issue Sep 7, 2023 · 0 comments
Labels
Bug There is a problem in our source code UI/UX Interfaces & user experience
Milestone

Comments

@davidbenque
Copy link
Contributor

Description

When attachment are large, CryptPad displays a button for the user to deliberately load them. In the Code/Markdown app preview it looks like this

image

However, when added to the description block in a Form, the button looks different. Title and text are all on one line, with spacing issues

image

I'd like to

  • understand why the button is displayed differently
  • correct the issue so that Form matches the display in other applications

Steps to reproduce

  1. upload a file (image, PDF, video) of more than 5MB
  2. give it a short name to highlight the issue
  3. embed the file in a Code document
  4. open this document in a private window to see the "load attachment" button and check that the it uses 2 lines for title and text
  5. embed the file in a Form description block
  6. open this form in a private window and see that the "load attachment" button title and text are displayed on one line with spacing issues

Relevant logs

No response

Expected behavior

The button should look the same in Form and in other apps

What opreating system are you using?

Linux/BSD/UNIX

What browsers are you seeing the problem on?

Mozilla Firefox

Extensions

uBlock Origin, Bitwarden

Version

5.4.1

@davidbenque davidbenque added the UI/UX Interfaces & user experience label Sep 7, 2023
@davidbenque davidbenque added this to the 5.5.0 milestone Sep 7, 2023
@ghost ghost added the Bug There is a problem in our source code label Sep 7, 2023
yflory added a commit that referenced this issue Sep 25, 2023
@yflory yflory added the Fixed in staging This is live on staging branch label Sep 25, 2023
@davidbenque davidbenque removed the Fixed in staging This is live on staging branch label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug There is a problem in our source code UI/UX Interfaces & user experience
Projects
None yet
Development

No branches or pull requests

2 participants