Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User menu displays may include consecutive separators #1402

Closed
ansuz opened this issue Feb 2, 2024 · 1 comment
Closed

User menu displays may include consecutive separators #1402

ansuz opened this issue Feb 2, 2024 · 1 comment
Labels
Bug There is a problem in our source code Drive Anything related to CryptPad interface, not apps Fixed in staging This is live on staging branch

Comments

@ansuz
Copy link
Contributor

ansuz commented Feb 2, 2024

Description

Under certain configurations it is possible for the dropdown user menu to display two consecutive separators.

Steps to reproduce

  1. as an administrator, check the Do not advertize crowdfunding campaigns checkbox on the admin panel's Network tab
  2. ensure that the instance does not have an active survey, configured via the admin panel's Broadcast tab in the Survey link field
  3. navigate to /drive/
  4. click the user admin menu in the top-right corner
  5. observe that two consecutive separators are displayed

image

Relevant logs

No response

Expected behavior

only one separator should be displayed between visible menu items

Which operating system are you using?

Linux/BSD/UNIX

What browsers are you seeing the problem on?

Mozilla Firefox

Extensions

Private firefox tab with no active extensions

Version

5.7.0

@yflory yflory added the Fixed in staging This is live on staging branch label Feb 7, 2024
@yflory
Copy link
Contributor

yflory commented Feb 7, 2024

Thanks for the report, this will be fixed in the next release!
The issue was caused by an incorrect selector due to the recent changes in the dropdowns for accessibility.
We also found another issue related to the "HTTP workers": Env was updated in these workers after 250ms but the server called back instantly after an admin decree, so the notification was sent too early to the users.

@mathilde-cryptpad mathilde-cryptpad added Bug There is a problem in our source code Drive Anything related to CryptPad interface, not apps labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug There is a problem in our source code Drive Anything related to CryptPad interface, not apps Fixed in staging This is live on staging branch
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants