fix issue #1054 by converting png to ico and linking them

[lemondevxyz]

Fixes #1054

Basically, all this commit does is create and execute a script (./customize.dist/favicon/convert.sh) that uses ImageMagick to convert various PNGs to ICOs(the format of favicon). It also adds the favicons to the HTML document through ./www/common/notify.js.

This commit may not affect https://realfavicongenerator.net/ because I think it doesn't execute Javascript judging from how fast it loads the website. (Favicons are injected through ./www/common/notify.js)

However, it will work in Chrome. Firefox doesn't work with this patch because it doesn't use the same internal mechanism(My theory that it fetches the HTML and since favicon gets injected with Javascript unnecessarily, it won't load the favicon).

I haven't tested this with Apple Safari yet.

I do not mind modifying all the various inner.html in the different applications to ensure favicon works on Firefox but I am not sure if this path is something that CryptPad is interested in.

[lemondevxyz]

I have added another commit to this branch. Now, Firefox will display icons for any bookmarked application. (I tested all of them)

Do note: This commit erases the ?version from the query of the favicon. I am not sure what is the purpose of this query but if it was important, one could create a script in the ./scripts folder that modifies the static favicons to include the version.

[wginolas]

Looks good to me. Can you remove unnecessary console.debug() calls and add ';' where it is missing?

[lemondevxyz]

Yes, of course. Check now!

[wginolas]

@lemondevxyz, can you commit the script customize.dist/favicon/convert.sh you mentioned to the scripts folder?

[wginolas]

This PR breaks the "icon notification" (the red dot) when a document has changed

[lemondevxyz]

@wginolas I added it. Do note is that it needs to be executed inside the scripts folder. If it is executed from the root directory of CryptPad, it wouldn't work. Also it uses ImageMagick.

As for the "icon notification", could you supply a screenshot of it? I tried going to https://cryptpad.fr - edited a document from different browsers and the favicon didn't change.