2 Factor Authentication (TOTP) #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we can more easily generate 'globally' unique identifiers
With this change media-tag now sends HTTP credentials when fetching blobs. Also changed the example nginx config to send Access-Control-Allow-Credentials CORS headers. For this to work, we can no longer use '*' for Access-Control-Allow-Origin [1][2]: Therefore the example config was changed to set Access-Control-Allow-Origin to the sandbox domain only. Fixes: - #705: Blob fetch fails with 401 Unauthorized when HTTP basic auth is enabled [3] Referenes: [1]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin [2]: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSNotSupportingCredentials [3]: #705
* use the nodejs cluster module to handle http traffic with multiple threads * listen for websocket traffic on a new port because all such logic needs to share state * proxy websocket URLs from the cluster to the new port so everything is backwards compatible * implement logic for http workers to make requests and stay in sync with the main process * unrelated: define the expected nodejs version in a constant
* make the websocket port configurable * reorder some tasks at launch time to use more consistent logging * relaunch http workers if they crash * refuse to launch if httpUnsafeOrigin cannot be parsed as a URL * fix a path issue reintroduced by a git merge
* remove commented code * serialize errors sent from http workers to the main process * drop support for custom http headers set via config.js#httpHeaders * websockets: only listen on localhost, respect websocketPort config in workers' proxy config
recovery page UI fixed
ghost
added
the
- making the message more generic so that it can be reused for the 2FA setting
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.