Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar accessibility improvements #1290

Merged
merged 93 commits into from Dec 13, 2023
Merged

Toolbar accessibility improvements #1290

merged 93 commits into from Dec 13, 2023

Conversation

davidbenque
Copy link
Contributor

@davidbenque davidbenque commented Oct 16, 2023 •
edited by dariiing

  • DOM order = tab order
  • Accessible drop-down menus
  • Accessible notifications menu and user menu

yflory and others added 30 commits August 31, 2023 16:34
@yflory
Reorder DOM based on visual order in toolbar #1198
2960921
@yflory
Fix CkEditor issue with toolbar reordering
784a833
@dariiing
user menu can be accessed
1f6b116 
using the keyboard on firefox
#1209
@dariiing
Merge remote-tracking branch 'origin/toolbar' into toolbar
d06c8e7
@dariiing
added focus to toolbar elements #1206
bd6de02 
user menu can be also accessed on other browsers #1209
@dariiing
Open Notification panel can be accessed with the keyboard #1201
71ec6d5
@dariiing
Allow notifications can be accessed with the keyboard #1201
154a550
@dariiing
notifications can be accessed with the keyboard #1201
c8c46d1
@dariiing
changed div to ul #1192
dfa2da2
@dariiing
modal can be accessed with the keyboard #1192
f1ae056
@dariiing
elements before "sheet" are now accessible via keyboard #1191
e855dd0
@dariiing
added aria-expanded #1191
3fd358f 
changed div into ul
@dariiing
can access Link from Filter dropdown
e4621c6
@dariiing
can access Remove filter from Filter dropdown
abe961a
@dariiing
changed span into h5 #1197
2d0e395
@dariiing
sidebar in drive is accessible via keyboard #1203
f9995b3
@dariiing
calendar can be created correctly using the keyboard
db85a85 
fixed #1250
@dariiing
team sidebar can be navigated using the keyboard #1162
424dc25
@dariiing
teams can be navigated using the keyboard #1162
e11487a
@dariiing
contacts can be navigated using the keyboard #1162
f95c223
@dariiing
settings sidebar can be navigated using the keyboard #1162
f7e0c6d
@dariiing
admin sidebar can be navigated using the keyboard #1162
a20a886
@dariiing
npm run lint
38db398
@dariiing
reverted db85a85
c0741a6
@dariiing
user menu(logged out) can be accessed with the keyboard #1209
3b21ca6
@dariiing
fixed indentation
29ba640
@dariiing
fixed button bug added in f1ae056
f5e8ad1
@dariiing
document title can be changed using only the keyboard
089e49b
@dariiing
focus starts on the toolbar
2f2a819
@dariiing
added role to element for screen readers
84727b0
dariiing and others added 29 commits November 12, 2023 20:48
@dariiing
added role to a elements on Filter dropdown
6cc377b
@dariiing
clicking outside the dropdown sets aria-expanded to false
e941b78
@dariiing
created function for reusability
e315ee2
@dariiing
dropdowns(+New and Filter) are accessible through keyboard
d890d26
@yflory
Revert autoformatting on "can access every link on user menu"
bc714f6 
This partially reverts commit 6b5eb38.
@yflory
Revert autoformatting on "navigation inside dropdown works correctly"
5c63caf 
This partially reverts commit ebfafea.
@yflory
Revert autoformatting on "temporary disabled keyboard access to drive…
de7b8e9 
… content"

This partially reverts commit 58daaa2.
@yflory
lint compliance
7fc3ff9
@yflory
Apply accessibility changes to all dropdowns
31c3148
@dariiing
can cycle through dropdown elements
814e795
@dariiing
Prevent default Tab key behavior on menu items
2711ea6
@dariiing
can navigate through notifications
e847118
@dariiing
deleted unnecessary code
cfefa95
@dariiing
can open notifications using the keyboard
f82ee3c
@dariiing
can delete notifications using the keyboard
eb350a7
@dariiing
fixed design issue occured on notification dropdown
5e027fe
@dariiing
matched dropdowns using the same amount of padding
f51ccd5
@yflory
Fix keydown issues with dropdowns
fa1e03c
@yflory
Merge branch 'toolbar-prototype' of github.com:cryptpad/cryptpad into…
922c77c 
… toolbar-prototype
@yflory
Merge branch 'staging' into toolbar-prototype
37debdb
@yflory
Fix style issues after the merge
93c185f
@dariiing
skip elements whose content is hidden
9f5fc1e
@dariiing
Filter dropdown is accessible using the keyboard
d1d2eb1
@dariiing
text color in user dropdown changes according to the color theme
ca03e81
@dariiing
lint compliance
d4ed31f
@yflory
Replace CSS parent selector :has (not supported by all browsers)
b7fd666
@yflory
Merge branch 'staging' into toolbar
ae11088
@yflory
Fix keydown event conflict between dropdown and drive
d5a321a
@yflory
Remove outline on drive content container when focused
01f13b6
@yflory yflory merged commit 16b5539 into staging Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dariiing dariiing

Labels
None yet
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidbenque @yflory @dariiing