Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few export-related issues #1328

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Fix a few export-related issues #1328

merged 5 commits into from
Nov 30, 2023

Conversation

Chouhartem
Copy link
Contributor

@Chouhartem Chouhartem commented Nov 21, 2023 •
edited
Loading

This PR tackles multiple issues, namely:

  1. No Whiteboard files when downloading Drive content #1267: this issues is solved with 51abbb4, it was an issue with the export module for the whiteboard application which automatically detects the size of the exported image, which is set to be 0×0 in the case of empty whiteboard. This kind of image could not be exported and resulted in a missing file. To sort this out, we decided to set a default size of 600×600 pixels for empty whiteboard to be consistent with the other empty-files export.
  2. While solving this, we also noticed that other whiteboard exports (from drive) were transparent PNG files (of the right size however) as described in Whiteboard export from drive is an empty PNG image #1324. This is fixed in 0005b93 and was due to a missing rendering of the canvas.
  3. Finally, while checking the behavior of different exports, we noticed that the Form exports were missing their extension, and it was fixed in 38b20e8

@Chouhartem
cryptpad#1324: Render the whiteboard before export
0005b93 
- The exported/downloaded from drive whiteboard was empty otherwise
@Chouhartem
Fix exported forms missing their extensions
38b20e8 
Related to cryptpad#1267 and cryptpad#1324
@Chouhartem
Set default size for empty whiteboard
51abbb4 
Previously, empty whiteboards were exported as a 0×0 pixel image, which
raised an error in fabric.js.
To address this issue, the default empty image is set to be a 600×600
pixel transparent png file.

Also fix cryptpad#1267 that is a consequence of the aforementioned issue.
@Chouhartem Chouhartem added Bug There is a problem in our source code Kanban Related to Kanban app Whiteboard Related to the Whiteboard app labels Nov 21, 2023
@Chouhartem Chouhartem added this to the 5.6.0 milestone Nov 21, 2023
@Chouhartem
Keypair not initialised correctly in the answers channel
e31965a 
- Bug introduced in cryptpad#1316 to fix cryptpad#1261
- Was an issue when creating a new form (impossible to answer), however
  importing a template fixed it.
- priv should stay in the scope of initializeAnswers() and not leak
@Chouhartem
Add a sanity check in initializeAnswers
5c762ed 
- To complete e31965a
@yflory yflory merged commit 1ca280c into cryptpad:staging Nov 30, 2023
@Chouhartem Chouhartem deleted the fix-whiteboard-download branch April 5, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug There is a problem in our source code Kanban Related to Kanban app Whiteboard Related to the Whiteboard app
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Chouhartem @yflory