mock: improve validateReplyParameters (nodejs#2783)

crysmags · Feb 27, 2024 · 9ed779f · 9ed779f
1 parent 640b136
commit 9ed779f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/mock/mock-interceptor.js b/lib/mock/mock-interceptor.js
@@ -106,7 +106,7 @@ class MockInterceptor {
     if (typeof data === 'undefined') {
       throw new InvalidArgumentError('data must be defined')
     }
-    if (typeof responseOptions !== 'object') {
+    if (typeof responseOptions !== 'object' || responseOptions === null) {
       throw new InvalidArgumentError('responseOptions must be an object')
     }
   }

diff --git a/test/mock-interceptor.js b/test/mock-interceptor.js
@@ -53,14 +53,15 @@ describe('MockInterceptor - reply callback', () => {
   })
 
   test('should error if passed options invalid', t => {
-    t = tspl(t, { plan: 2 })
+    t = tspl(t, { plan: 3 })
 
     const mockInterceptor = new MockInterceptor({
       path: '',
       method: ''
     }, [])
     t.throws(() => mockInterceptor.reply(), new InvalidArgumentError('statusCode must be defined'))
     t.throws(() => mockInterceptor.reply(200, () => { }, 'hello'), new InvalidArgumentError('responseOptions must be an object'))
+    t.throws(() => mockInterceptor.reply(200, () => { }, null), new InvalidArgumentError('responseOptions must be an object'))
   })
 })