fix: clear set-cookie headers (nodejs#2052)

crysmags · Feb 27, 2024 · cf3d9df · cf3d9df
1 parent 1a7d604
commit cf3d9df
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/fetch/headers.js b/lib/fetch/headers.js
@@ -95,6 +95,7 @@ class HeadersList {
   clear () {
     this[kHeadersMap].clear()
     this[kHeadersSortedMap] = null
+    this.cookies = null
   }
 
   // https://fetch.spec.whatwg.org/#concept-header-list-append

diff --git a/test/fetch/request.js b/test/fetch/request.js
@@ -460,3 +460,19 @@ test('constructing Request with third party FormData body', async (t) => {
   t.equal(contentType[0], 'multipart/form-data; boundary')
   t.ok((await req.text()).startsWith(`--${contentType[1]}`))
 })
+
+// https://github.com/nodejs/undici/issues/2050
+test('set-cookie headers get cleared when passing a Request as first param', (t) => {
+  const req1 = new Request('http://localhost', {
+    headers: {
+      'set-cookie': 'a=1'
+    }
+  })
+
+  t.same([...req1.headers], [['set-cookie', 'a=1']])
+  const req2 = new Request(req1, { headers: {} })
+
+  t.same([...req2.headers], [])
+  t.same(req2.headers.getSetCookie(), [])
+  t.end()
+})