fix request's arrayBuffer returning uint8 instead of arraybuffer (nod…

…ejs#2344)
crysmags · Feb 27, 2024 · d4abe03 · d4abe03
1 parent bbd955c
commit d4abe03
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/api/readable.js b/lib/api/readable.js
@@ -268,7 +268,7 @@ function consumeEnd (consume) {
         pos += buf.byteLength
       }
 
-      resolve(dst)
+      resolve(dst.buffer)
     } else if (type === 'blob') {
       if (!Blob) {
         Blob = require('buffer').Blob

diff --git a/test/client-request.js b/test/client-request.js
@@ -413,7 +413,7 @@ test('request blob', { skip: nodeMajor < 16 }, (t) => {
 })
 
 test('request arrayBuffer', (t) => {
-  t.plan(1)
+  t.plan(2)
 
   const obj = { asd: true }
   const server = createServer((req, res) => {
@@ -429,7 +429,10 @@ test('request arrayBuffer', (t) => {
       path: '/',
       method: 'GET'
     })
-    t.strictSame(Buffer.from(JSON.stringify(obj)), Buffer.from(await body.arrayBuffer()))
+    const ab = await body.arrayBuffer()
+
+    t.strictSame(Buffer.from(JSON.stringify(obj)), Buffer.from(ab))
+    t.ok(ab instanceof ArrayBuffer)
   })
 })