Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks: Add blake2{b,s}_{32,vec128,vec256,EverCrypt}_streaming benchmarks. #323

Merged
merged 10 commits into from
Jan 23, 2023

Conversation

duesee
Copy link
Contributor

@duesee duesee commented Jan 6, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 6, 2023
@duesee duesee mentioned this pull request Jan 6, 2023
59 tasks
@coveralls
Copy link

coveralls commented Jan 6, 2023

Pull Request Test Coverage Report for Build 3986059768

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.588%

Totals Coverage Status
Change from base Build 3985525251: 0.0%
Covered Lines: 30653
Relevant Lines: 57201

💛 - Coveralls

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add the benchmark to the config.json to enable it.

@duesee
Copy link
Contributor Author

duesee commented Jan 13, 2023

You have to add the benchmark to the config.json to enable it.

benchmarks/blake.cc is already in the config.json.

@duesee duesee marked this pull request as ready for review January 13, 2023 11:21
@duesee duesee requested a review from a team as a code owner January 13, 2023 11:21
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm with those two suggestions.

benchmarks/blake.cc Outdated Show resolved Hide resolved
benchmarks/blake.cc Outdated Show resolved Hide resolved
Thanks, @franziskuskiefer!

Co-authored-by: Franziskus Kiefer <franziskuskiefer@gmail.com>
@duesee duesee enabled auto-merge (squash) January 13, 2023 11:49
@duesee duesee disabled auto-merge January 13, 2023 13:14
@duesee duesee changed the title Add benchmarks. benchmarks: Add blake2{b,s}_{32,vec128,vec256,EverCrypt}_streaming benchmarks. Jan 13, 2023
@franziskuskiefer franziskuskiefer enabled auto-merge (squash) January 14, 2023 09:34
@franziskuskiefer
Copy link
Member

This doesn't compile in all configurations

/usr/bin/ld: blake.cc:(.text+0x1068): undefined reference to `Hacl_Streaming_Blake2b_256_blake2b_256_no_key_free'
/usr/bin/ld: blake.cc:(.text+0x1089): undefined reference to `Hacl_Streaming_Blake2b_256_blake2b_256_no_key_create_in'
/usr/bin/ld: blake.cc:(.text+0x1095): undefined reference to `Hacl_Streaming_Blake2b_256_blake2b_256_no_key_init'
/usr/bin/ld: blake.cc:(.text+0x11b2): undefined reference to `Hacl_Streaming_Blake2b_256_blake2b_256_no_key_update'

@franziskuskiefer
Copy link
Member

Looks like the regression testing is working... But this looks more like a benchmark that needs to be changed.

@duesee duesee enabled auto-merge (squash) January 23, 2023 11:48
@duesee duesee merged commit 92bc679 into main Jan 23, 2023
@duesee duesee deleted the duesee/issue_37_1 branch January 23, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants