Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NaCl benchmark #326

Merged
merged 1 commit into from
Jan 11, 2023
Merged

NaCl benchmark #326

merged 1 commit into from
Jan 11, 2023

Conversation

pnmadelaine
Copy link
Collaborator

Add a benchmark for NaCl.

@pnmadelaine pnmadelaine requested a review from a team as a code owner January 10, 2023 10:29
@cla-bot cla-bot bot added the cla-signed label Jan 10, 2023
duesee
duesee reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@duesee duesee left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me and is even less verbose than I expected :-)

I checked that the correct functions are called, the benchmark are executed, and that all defines and static variables are correct.

One question and then this should be good to go.

benchmarks/nacl.cc Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3883543201

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.588%
Totals Coverage Status
Change from base Build 3883379237: 0.0%
Covered Lines: 30653
Relevant Lines: 57201
💛 - Coveralls

@franziskuskiefer franziskuskiefer enabled auto-merge (squash) January 11, 2023 07:03
@franziskuskiefer franziskuskiefer merged commit 9877ecb into main Jan 11, 2023
@franziskuskiefer franziskuskiefer deleted the pnmadelaine-nacl-benchmark branch January 11, 2023 07:19
@duesee duesee mentioned this pull request Jan 13, 2023
Closed
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duesee duesee duesee approved these changes

@franziskuskiefer franziskuskiefer Awaiting requested review from franziskuskiefer

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pnmadelaine @coveralls @franziskuskiefer @duesee