Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL benchmarks #329

Merged
merged 5 commits into from
Feb 7, 2023
Merged

OpenSSL benchmarks #329

merged 5 commits into from
Feb 7, 2023

Conversation

pnmadelaine
Copy link
Collaborator

Add OpenSSL benchmarks for comparison.

@cla-bot cla-bot bot added the cla-signed label Jan 10, 2023
@coveralls
Copy link

coveralls commented Jan 10, 2023 •
edited

Pull Request Test Coverage Report for Build 4114119557

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.642%
Totals Coverage Status
Change from base Build 4111023957: 0.0%
Covered Lines: 30549
Relevant Lines: 56950
💛 - Coveralls

franziskuskiefer
franziskuskiefer requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good but it needs to be guarded to allow disabling it.

benchmarks/sha3.cc Outdated Show resolved Hide resolved
@franziskuskiefer
Copy link
Member

Not sure if this was ready for review already, just a drive-by.

duesee
duesee reviewed Jan 13, 2023
View reviewed changes
benchmarks/sha3.cc Outdated Show resolved Hide resolved
@pnmadelaine pnmadelaine marked this pull request as ready for review February 7, 2023 12:58
@pnmadelaine pnmadelaine requested a review from a team as a code owner February 7, 2023 12:58
duesee
duesee approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks very good to me.

@duesee duesee enabled auto-merge (rebase) February 7, 2023 13:27
@franziskuskiefer franziskuskiefer requested review from franziskuskiefer and removed request for franziskuskiefer February 7, 2023 13:29
@duesee duesee merged commit 381918d into main Feb 7, 2023
@duesee duesee deleted the pnmadelaine-openssl-benchmarks branch February 7, 2023 13:30
@pnmadelaine pnmadelaine mentioned this pull request Feb 7, 2023
Closed
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@duesee duesee duesee approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pnmadelaine @coveralls @franziskuskiefer @duesee