Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks: Add Ed25519 benchmarks (OpenSSL + Precomputed). #334

Closed
wants to merge 7 commits into from
Closed

benchmarks: Add Ed25519 benchmarks (OpenSSL + Precomputed). #334

wants to merge 7 commits into from

Conversation

duesee
Copy link
Contributor

@duesee duesee commented Jan 13, 2023

No description provided.

@duesee duesee requested a review from a team as a code owner January 13, 2023 14:53
@cla-bot cla-bot bot added the cla-signed label Jan 13, 2023
@coveralls
Copy link

coveralls commented Jan 13, 2023 •
edited

Pull Request Test Coverage Report for Build 3913218403

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.588%
Totals Coverage Status
Change from base Build 3912962990: 0.0%
Covered Lines: 30653
Relevant Lines: 57201
💛 - Coveralls

@duesee duesee mentioned this pull request Jan 13, 2023
Closed
59 tasks
franziskuskiefer
franziskuskiefer approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that include there is unnecessary. Otherwise this lgtm.

benchmarks/ed25519.cc Outdated Show resolved Hide resolved
franziskuskiefer pushed a commit that referenced this pull request Jan 14, 2023
@duesee
benchmarks: Add Ed25519 benchmarks (OpenSSL + Precomputed). (#334)
2b4849e 
* benchmarks: Don't check validity of Ed25519 signature in benchmarks.
* benchmarks: Add Ed25519 signature benchmark that uses precomputation.
* benchmarks: Deduplicate `sk`, `msg` in Ed25519 benchmarks.
* benchmarks: Add Ed25519 OpenSSL benchmark.
@franziskuskiefer franziskuskiefer enabled auto-merge (squash) January 14, 2023 09:45
@franziskuskiefer
Copy link
Member

This is weird. This was merged to main but it's still open.

franziskuskiefer pushed a commit that referenced this pull request Jan 23, 2023
@duesee @franziskuskiefer
benchmarks: Add Ed25519 benchmarks (OpenSSL + Precomputed). (#334)
2c44855 
* benchmarks: Don't check validity of Ed25519 signature in benchmarks.
* benchmarks: Add Ed25519 signature benchmark that uses precomputation.
* benchmarks: Deduplicate `sk`, `msg` in Ed25519 benchmarks.
* benchmarks: Add Ed25519 OpenSSL benchmark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duesee @coveralls @franziskuskiefer