Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks: HKDF. #335

Merged
merged 3 commits into from
Jan 16, 2023
Merged

benchmarks: HKDF. #335

merged 3 commits into from
Jan 16, 2023

Conversation

duesee
Copy link
Contributor

@duesee duesee commented Jan 13, 2023

No description provided.

@duesee duesee requested a review from a team as a code owner January 13, 2023 16:45
@cla-bot cla-bot bot added the cla-signed label Jan 13, 2023
@duesee duesee mentioned this pull request Jan 13, 2023
Closed
59 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3913232470

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.588%
Totals Coverage Status
Change from base Build 3912962990: 0.0%
Covered Lines: 30653
Relevant Lines: 57201
💛 - Coveralls

franziskuskiefer
franziskuskiefer requested changes Jan 14, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but we should use names that are easier to read (and more in line with what we have).

benchmarks/kdf.cc Show resolved Hide resolved
@duesee duesee merged commit 87c3405 into main Jan 16, 2023
@duesee duesee deleted the duesee/issues_37_3 branch January 16, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duesee @coveralls @franziskuskiefer