Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks: Add HMAC benchmarks. #341

Merged
merged 7 commits into from
Jan 23, 2023
Merged

benchmarks: Add HMAC benchmarks. #341

merged 7 commits into from
Jan 23, 2023

Conversation

duesee
Copy link
Contributor

@duesee duesee commented Jan 19, 2023

A bit of copy-paste. Deduplication of code doesn't make it a lot better, though. Given that we don't want to change that, it's okay IMO.

@duesee duesee requested a review from a team as a code owner January 19, 2023 10:36
@cla-bot cla-bot bot added the cla-signed label Jan 19, 2023
@duesee duesee mentioned this pull request Jan 19, 2023
Closed
59 tasks
@duesee duesee marked this pull request as draft January 19, 2023 10:43
franziskuskiefer
franziskuskiefer requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot the measurements 😉
Otherwise, lgtm.

@duesee duesee marked this pull request as ready for review January 19, 2023 10:46
franziskuskiefer
franziskuskiefer approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's better 😄

@duesee duesee enabled auto-merge (rebase) January 19, 2023 10:54
@coveralls
Copy link

coveralls commented Jan 19, 2023 •
edited

Pull Request Test Coverage Report for Build 3987478681

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.642%
Totals Coverage Status
Change from base Build 3987476663: 0.0%
Covered Lines: 30549
Relevant Lines: 56950
💛 - Coveralls

auto-merge was automatically disabled January 19, 2023 12:43

Rebase failed

@duesee duesee enabled auto-merge (rebase) January 19, 2023 15:20
auto-merge was automatically disabled January 23, 2023 12:26

Rebase failed

@duesee duesee enabled auto-merge (squash) January 23, 2023 12:33
@duesee duesee merged commit 54e85dd into main Jan 23, 2023
@duesee duesee deleted the duesee/issue_37_6 branch January 23, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duesee @coveralls @franziskuskiefer