Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to HACL* ae5d839c2e1fa95055b618cda60aeb1c486c720c #377

Merged
merged 35 commits into from
Nov 28, 2023

Conversation

pnmadelaine
Copy link
Collaborator

@cla-bot cla-bot bot added the cla-signed label Mar 13, 2023
@coveralls
Copy link

coveralls commented Mar 13, 2023

Pull Request Test Coverage Report for Build 7023476406

  • 10591 of 20338 (52.07%) changed or added relevant lines in 76 files are covered.
  • 73 unchanged lines in 24 files lost coverage.
  • Overall coverage increased (+1.2%) to 54.055%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Hacl_Frodo_KEM.c 0 1 0.0%
src/EverCrypt_AutoConfig2.c 13 16 81.25%
src/EverCrypt_HKDF.c 75 78 96.15%
src/Hacl_Hash_SHA1.c 121 132 91.67%
src/Hacl_GenericField32.c 84 97 86.6%
src/Hacl_HKDF_Blake2b_256.c 0 13 0.0%
src/Hacl_HKDF_Blake2s_128.c 0 13 0.0%
src/Hacl_RSAPSS.c 151 165 91.52%
src/Hacl_HKDF.c 50 65 76.92%
src/Hacl_MAC_Poly1305.c 647 663 97.59%
Files with Coverage Reduction New Missed Lines %
src/EverCrypt_DRBG.c 1 15.15%
src/Hacl_GenericField64.c 1 86.46%
src/Hacl_K256_ECDSA.c 1 89.47%
src/Hacl_RSAPSS.c 1 85.87%
src/EverCrypt_AEAD.c 2 28.55%
src/Hacl_Bignum32.c 2 8.84%
src/Hacl_Bignum64.c 2 8.84%
src/Hacl_Hash_MD5.c 2 81.97%
src/Hacl_SHA2_Vec128.c 2 0.0%
src/Hacl_Bignum4096_32.c 3 61.84%
Totals Coverage Status
Change from base Build 6482173544: 1.2%
Covered Lines: 27829
Relevant Lines: 51483

💛 - Coveralls

* merge branch 'main' into pnmadelaine-update

* update to HACL* 45b18730573d3404a57fb63767570cb97897a75f
@pnmadelaine pnmadelaine reopened this Nov 7, 2023
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I left some comments.

Also: the docs will need to be updated as well.

benchmarks/sha2.cc Show resolved Hide resolved
benchmarks/sha3.cc Show resolved Hide resolved
benchmarks/sha2.cc Show resolved Hide resolved
rust/hacl-sys/build.rs Outdated Show resolved Hide resolved
@pnmadelaine pnmadelaine marked this pull request as ready for review November 21, 2023 11:26
@pnmadelaine pnmadelaine requested a review from a team as a code owner November 21, 2023 11:26
@pnmadelaine pnmadelaine changed the title update update to HACL* ae5d839c2e1fa95055b618cda60aeb1c486c720c Nov 21, 2023
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like this is almost good to go.
What's the state of the docs? They seem to still use the old file- and function names.

benchmarks/sha2.cc Show resolved Hide resolved
rust/hacl-sys/build.rs Outdated Show resolved Hide resolved
@franziskuskiefer
Copy link
Member

@pnmadelaine can you update the documentation and look if there's any other comment open? I think this is ready to go otherwise.

@franziskuskiefer franziskuskiefer merged commit 484a64f into main Nov 28, 2023
38 checks passed
@franziskuskiefer franziskuskiefer deleted the pnmadelaine-update branch November 28, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants