Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust cleanup ctd... #379

Merged
merged 27 commits into from
Mar 21, 2023
Merged

rust cleanup ctd... #379

merged 27 commits into from
Mar 21, 2023

Conversation

franziskuskiefer
Copy link
Member

More Rust binding changes, in particular hazmat APIs

  • cpu feature detection
  • slightly better error handling
  • expose Ed25519, DRBG, and AES-GM in hazmat APIs

franziskuskiefer and others added 25 commits January 27, 2023 15:30
@franziskuskiefer
fix rust hazmat sha2 streaming
9c86bcc
@franziskuskiefer
sha2 streaming mutability
1a47e67
@franziskuskiefer
add hmac and hkdf
3ce5eed
@franziskuskiefer
hkdf hmac reorg
d46bb9e
@franziskuskiefer
add errors to hkdf
a2bb38b
@franziskuskiefer
Merge branch 'main' into franziskus/rust-cleanup-4
fdf311e
@franziskuskiefer
add sha384 hkdf
56c49d1
@franziskuskiefer
Create devcontainer.json
8308ae9
@franziskuskiefer
fix simd256
ab5faf0
@franziskuskiefer @duesee
Apply suggestions from code review
f849fa7 
Co-authored-by: Damian Poddebniak <poddebniak@mailbox.org>
@franziskuskiefer
don't panic in hkdf
1b41e33
@franziskuskiefer
add build.rs to Rust library
df3cefc
@franziskuskiefer
remove config.toml
62527ea
@franziskuskiefer
Merge branch 'main' into franziskus/rust-cleanup-5
1c2357f
@franziskuskiefer
Merge branch 'main' into franziskus/rust-cleanup-5
0f3e65c
@franziskuskiefer
Merge branch 'main' into franziskus/rust-cleanup-5
8799561
@franziskuskiefer
use streaming for sha2 oneshot
109efb1
@franziskuskiefer
add drbg to hazma api
969d924
@franziskuskiefer
Merge branch 'main' into franziskus/rust-cleanup-5
fd92d69
@franziskuskiefer
more hazmat apis
2640dde
@franziskuskiefer
errors
f069c94
@franziskuskiefer
fixup vale x25519
4bedebd
@franziskuskiefer
wip
aec65b9
@franziskuskiefer
aesgcm hazmat
b67fd5b
@franziskuskiefer
Merge branch 'main' into franziskus/rust-cleanup-5
3e43f89
@franziskuskiefer franziskuskiefer requested a review from a team as a code owner March 20, 2023 11:45
@cla-bot cla-bot bot added the cla-signed label Mar 20, 2023
@franziskuskiefer franziskuskiefer mentioned this pull request Mar 20, 2023
Open
9 tasks
@coveralls
Copy link

coveralls commented Mar 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4472012050

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.441%
Totals Coverage Status
Change from base Build 4315071413: 0.0%
Covered Lines: 30398
Relevant Lines: 56881
💛 - Coveralls

duesee
duesee suggested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@duesee duesee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some (optional) suggestions and some requests for changes.

rust/src/hazmat/aesgcm.rs Show resolved Hide resolved
rust/src/hazmat/aesgcm.rs Outdated Show resolved Hide resolved
rust/src/hazmat/aesgcm.rs Outdated Show resolved Hide resolved
rust/src/hazmat/aesgcm.rs Show resolved Hide resolved
rust/src/hazmat/drbg.rs Outdated Show resolved Hide resolved
rust/src/hazmat/drbg.rs Outdated Show resolved Hide resolved
rust/src/hazmat/p256.rs Show resolved Hide resolved
rust/src/hazmat/p256.rs Show resolved Hide resolved
rust/src/hazmat.rs Show resolved Hide resolved
rust/build.rs Outdated Show resolved Hide resolved
duesee
duesee approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@franziskuskiefer franziskuskiefer merged commit 428d84c into main Mar 21, 2023
@franziskuskiefer franziskuskiefer deleted the franziskus/rust-cleanup-5 branch March 21, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duesee duesee duesee approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@franziskuskiefer @coveralls @duesee