Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hacl to ad60c9d98c9ce8f6a4fa13090511fa4b3a2c137b #426

Merged
merged 10 commits into from
Sep 27, 2023
Merged

update hacl to ad60c9d98c9ce8f6a4fa13090511fa4b3a2c137b #426

merged 10 commits into from
Sep 27, 2023

Conversation

franziskuskiefer
Copy link
Member

There are some manual changes to fixup hacl-star/hacl-star#844

@franziskuskiefer franziskuskiefer requested a review from a team as a code owner September 13, 2023 16:29
@cla-bot cla-bot bot added the cla-signed label Sep 13, 2023
@franziskuskiefer franziskuskiefer mentioned this pull request Sep 13, 2023
Merged
@coveralls
Copy link

coveralls commented Sep 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6321338060

  • 273 of 923 (29.58%) changed or added relevant lines in 41 files are covered.
  • 22 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 52.864%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Hacl_Bignum.c 15 16 93.75%
src/Hacl_Hash_Blake2b_256.c 4 5 80.0%
src/Hacl_Hash_Blake2s_128.c 4 5 80.0%
src/Hacl_Hash_MD5.c 0 1 0.0%
src/Hacl_Streaming_Blake2s_128.c 0 1 0.0%
src/Hacl_Streaming_Poly1305_256.c 0 1 0.0%
src/EverCrypt_HMAC.c 34 36 94.44%
src/Hacl_HMAC.c 34 36 94.44%
src/Hacl_Bignum256.c 8 11 72.73%
src/Hacl_Bignum256_32.c 8 11 72.73%
Files with Coverage Reduction New Missed Lines %
src/EverCrypt_Curve25519.c 1 93.75%
src/EverCrypt_Hash.c 1 67.64%
src/EverCrypt_AEAD.c 4 28.23%
src/EverCrypt_DRBG.c 16 15.23%
Totals Coverage Status
Change from base Build 5829255803: 0.1%
Covered Lines: 29033
Relevant Lines: 54920
💛 - Coveralls

@franziskuskiefer franziskuskiefer mentioned this pull request Sep 15, 2023
Merged
@franziskuskiefer franziskuskiefer added this pull request to the merge queue Sep 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 27, 2023
@franziskuskiefer franziskuskiefer changed the title update hacl to a9146dc1bf9671406bccde3d9b66e72742349698 update hacl to ad60c9d98c9ce8f6a4fa13090511fa4b3a2c137b Sep 27, 2023
@franziskuskiefer franziskuskiefer merged commit bb6620a into main Sep 27, 2023
38 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/update-hacl branch September 27, 2023 07:16
mamonet pushed a commit to mamonet/hacl-packages that referenced this pull request Dec 1, 2023
@franziskuskiefer @mamonet
update hacl to ad60c9d98c9ce8f6a4fa13090511fa4b3a2c137b (cryspen#426)
cc960ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed
Projects
HACL Packages
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@franziskuskiefer @coveralls